Merged
Conversation
jbudz
force-pushed
the
docs-breaking-changes
branch
from
51143e4 to
61545cd
Compare
Contributor
|
I think these should go in 5.x and get backported to 5.0. That seems to be the way elasticsearch does it https://www.elastic.co/guide/en/elasticsearch/reference/5.x/breaking-changes.html I'd also recommend following the tree structure that ES uses, so everything looks nice and consistent across products, so: Breaking changes |
Contributor
|
We're gonna have to get better about applying the breaking label to PRs now, 3/4 of those you listed didn't have it :) |
jbudz
force-pushed
the
docs-breaking-changes
branch
from
61545cd to
b3e1aaa
Compare
Bargs
suggested changes
Oct 6, 2016
docs/breaking-changes.asciidoc
Outdated
Contributor
There was a problem hiding this comment.
The "c" should be capitalized in changes so it matches the other section titles in the table of contents
Contributor
|
I think this needs to be rebased as well |
jbudz
force-pushed
the
docs-breaking-changes
branch
from
e208cbf to
743c132
Compare
Bargs
approved these changes
Oct 10, 2016
Contributor
|
@jbudz I'm going to point this against master instead. It clearly lists it as breaking changes in 5.0, so there's no reason why that can't go into master. |
Contributor
|
Nevermind, just changing it via github doesn't work. Can you point these changes at master instead? |
jbudz
force-pushed
the
docs-breaking-changes
branch
from
743c132 to
f10a949
Compare
Contributor
Author
|
@epixa done |
Contributor
|
LGTM, let's get this in/backported |
elastic-jasper
added a commit
that referenced
this pull request
Oct 10, 2016
--------- **Commit 1:** [docs] Init breaking changes * Original sha: 3e60953 * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-09-15T17:35:44Z **Commit 2:** [docs] Add separate section for 5.0 * Original sha: 9f0101f * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-09-15T19:09:36Z **Commit 3:** [docs] Capitalize breaking changes title * Original sha: f10a949 * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-10-10T14:17:01Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 10, 2016
--------- **Commit 1:** [docs] Init breaking changes * Original sha: 3e60953 * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-09-15T17:35:44Z **Commit 2:** [docs] Add separate section for 5.0 * Original sha: 9f0101f * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-09-15T19:09:36Z **Commit 3:** [docs] Capitalize breaking changes title * Original sha: f10a949 * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-10-10T14:17:01Z
This was referenced Oct 10, 2016
epixa
added a commit
that referenced
this pull request
Oct 10, 2016
[backport] PR #8301 to 5.x - [docs] Init breaking changes
epixa
added a commit
that referenced
this pull request
Oct 10, 2016
[backport] PR #8301 to 5.0 - [docs] Init breaking changes
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** [docs] Init breaking changes * Original sha: bc4a7096b972e98479300411ed134b40eb083872 [formerly 3e60953] * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-09-15T17:35:44Z **Commit 2:** [docs] Add separate section for 5.0 * Original sha: 02e0808655b09fb436490218ee9cce63ae29a841 [formerly 9f0101f] * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-09-15T19:09:36Z **Commit 3:** [docs] Capitalize breaking changes title * Original sha: e9d72049cccb047293f6bff1f262187dabc718e1 [formerly f10a949] * Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-10-10T14:17:01Z Former-commit-id: 8189d1b
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8301 to 5.x - [docs] Init breaking changes Former-commit-id: e5b1121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This starts a breaking changes section in the kibana docs. Part of #8077. cc @tbragin @epixa